AndreFerreira5/starranja
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

Implement RBAC auth routes and tests (#16) #161

Merged
Rodrigo2003-PT merged 4 commits from feature/16-rbac-middleware into main 2025-12-12 02:09:23 +00:00
Conversation 7 Commits 4 Files changed 8 +1677 -314
Rodrigo2003-PT commented 2025-12-09 19:53:27 +00:00 (Migrated from github.com)
Copy link
No description provided.
AndreFerreira5 (Migrated from github.com) reviewed 2025-12-09 19:53:27 +00:00
duarteneves5 (Migrated from github.com) requested changes 2025-12-11 17:05:46 +00:00
src/routes/users.py
@ -2,13 +2,13 @@ from typing import Annotated
duarteneves5 (Migrated from github.com) commented 2025-12-11 17:05:04 +00:00
Copy link

having the prefix="/users" is incorrect. the APIRouter will automatically get the file name for its route name. Having the prefix="users" the route will be /users/users, which is incorrect. To solve this just remove the prefix="/users"

having the prefix="/users" is incorrect. the APIRouter will automatically get the file name for its route name. Having the prefix="users" the route will be /users/users, which is incorrect. To solve this just remove the prefix="/users"
duarteneves5 (Migrated from github.com) requested changes 2025-12-11 17:13:07 +00:00
duarteneves5 (Migrated from github.com) left a comment
Copy link

resolve this

resolve this
duarteneves5 (Migrated from github.com) requested changes 2025-12-11 17:16:11 +00:00
src/authentication/decorators.py
@ -0,0 +1,309 @@
"""
duarteneves5 (Migrated from github.com) commented 2025-12-11 17:15:34 +00:00
Copy link

this is litterally a block of code that the AI shows you when answering, please remove it.

this is litterally a block of code that the AI shows you when answering, please remove it.
duarteneves5 (Migrated from github.com) commented 2025-12-11 17:15:38 +00:00
Copy link

this is litterally a block of code that the AI shows you when answering, please remove it.

this is litterally a block of code that the AI shows you when answering, please remove it.
duarteneves5 (Migrated from github.com) requested changes 2025-12-11 17:17:22 +00:00
src/authentication/decorators.py
@ -0,0 +1,309 @@
"""
duarteneves5 (Migrated from github.com) commented 2025-12-11 17:17:15 +00:00
Copy link

remove this AI slop

remove this AI slop
Cordeir01 (Migrated from github.com) reviewed 2025-12-12 01:16:51 +00:00
Copilot commented 2025-12-12 01:39:39 +00:00 (Migrated from github.com)
Copy link

@AndreFerreira5 I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you.

@AndreFerreira5 I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you.
Sign in to join this conversation.
Reviewers
No reviewers
AndreFerreira5
duarteneves5
Labels
Clear labels   
CI/CD

   
MongoDB

   
PostgreSQL

   
api

   
authentication

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
example issue

issue that aims to show how to create issues

  
fix

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
high-level requirement

   
infrastructure

   
invalid

This doesn't seem right

  
low-level requirement

   
medium-level requirement

   
question

Further information is requested

  
security

   
test

   
wontfix

This will not be worked on

No labels
CI/CD
MongoDB
PostgreSQL
api
authentication
bug
documentation
duplicate
enhancement
example issue
fix
good first issue
help wanted
high-level requirement
infrastructure
invalid
low-level requirement
medium-level requirement
question
security
test
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AndreFerreira5/starranja!161
No description provided.