mlflow: trying to fix artiifacts not showing up and data not persisti… #35

Merged
AndreFerreira5 merged 1 commit from pipeline-overhaul into main 2025-12-04 00:58:07 +00:00
AndreFerreira5 commented 2025-12-04 00:57:57 +00:00 (Migrated from github.com)

…ng between sessions

…ng between sessions
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-12-04 01:01:04 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

This PR aims to fix MLflow artifacts not displaying and data persistence issues between sessions by modifying the MLflow server configuration and Docker Compose setup.

Key Changes:

  • Updated SQLite database path from relative to absolute path in both entrypoint script and compose file
  • Consolidated Docker volume mounts from two separate mounts (./mlruns and ./data) to a single mount (./ml_data)
  • Enabled the --serve-artifacts flag in the MLflow server entrypoint

Note: The PR title contains a typo: "artiifacts" should be "artifacts"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/mlflow-server/mlflow-entrypoint.sh Updated backend store URI to use absolute path, enabled artifact serving, and added missing line continuation backslash
mlflow.compose.v1.yml Updated environment variable for backend store URI and consolidated volume mounts to single directory
## Pull request overview This PR aims to fix MLflow artifacts not displaying and data persistence issues between sessions by modifying the MLflow server configuration and Docker Compose setup. **Key Changes:** - Updated SQLite database path from relative to absolute path in both entrypoint script and compose file - Consolidated Docker volume mounts from two separate mounts (`./mlruns` and `./data`) to a single mount (`./ml_data`) - Enabled the `--serve-artifacts` flag in the MLflow server entrypoint **Note:** The PR title contains a typo: "artiifacts" should be "artifacts" ### Reviewed changes Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments. | File | Description | | ---- | ----------- | | src/mlflow-server/mlflow-entrypoint.sh | Updated backend store URI to use absolute path, enabled artifact serving, and added missing line continuation backslash | | mlflow.compose.v1.yml | Updated environment variable for backend store URI and consolidated volume mounts to single directory |
@ -6,3 +6,3 @@
environment:
- BACKEND_STORE_URI=sqlite:///mlflow/mlflow.db
- BACKEND_STORE_URI=sqlite:////mlflow/mlflow.db
ports:
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-04 01:01:04 +00:00

The SQLite URI has four slashes (sqlite:////), but the standard format for an absolute path is three slashes (sqlite:///). Change to sqlite:///mlflow/mlflow.db for the correct format.

      - BACKEND_STORE_URI=sqlite:///mlflow/mlflow.db
The SQLite URI has four slashes (`sqlite:////`), but the standard format for an absolute path is three slashes (`sqlite:///`). Change to `sqlite:///mlflow/mlflow.db` for the correct format. ```suggestion - BACKEND_STORE_URI=sqlite:///mlflow/mlflow.db ```
@ -5,3 +5,3 @@
--port 3030 \
--backend-store-uri sqlite:///mlflow.db \
--backend-store-uri sqlite:////mlflow/mlflow.db \
--default-artifact-root /mlflow/mlruns \
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-04 01:01:03 +00:00

The SQLite URI has four slashes (sqlite:////), but the standard format for an absolute path is three slashes (sqlite:///). Change to sqlite:///mlflow/mlflow.db for the correct format.

  --backend-store-uri sqlite:///mlflow/mlflow.db \
The SQLite URI has four slashes (`sqlite:////`), but the standard format for an absolute path is three slashes (`sqlite:///`). Change to `sqlite:///mlflow/mlflow.db` for the correct format. ```suggestion --backend-store-uri sqlite:///mlflow/mlflow.db \ ```
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-04 01:01:04 +00:00

Setting --allowed-hosts "*" disables host header restrictions, allowing requests with arbitrary Host values. Attackers can exploit this to perform host header poisoning, cache poisoning, or redirect attacks via crafted links, especially behind proxies. Restrict --allowed-hosts to known hostnames (e.g., example.com,localhost) instead of "*".

  --allowed-hosts "localhost,example.com" \
Setting `--allowed-hosts "*"` disables host header restrictions, allowing requests with arbitrary `Host` values. Attackers can exploit this to perform host header poisoning, cache poisoning, or redirect attacks via crafted links, especially behind proxies. Restrict `--allowed-hosts` to known hostnames (e.g., `example.com,localhost`) instead of `"*"`. ```suggestion --allowed-hosts "localhost,example.com" \ ```
Sign in to join this conversation.
No description provided.